Minor fixes #687
Closed
Minor fixes #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexflorisca
commented
Nov 7, 2014
alexflorisca
commented
- Response in express of the form "res.send(status, message)" has been deprecated. Updated responses to use the updated format of "res.status(xxx).json(object)" or "res.status(xxx).end()"
- Fix: If the :id attribute in the API does not evaluate to a valid mongoose ObjectID, it produces a Cast error.
- Removed some unnecessary dependency injections where they were not being used.
- Response in express of the form "res.send(status, message)" has been deprecated. Updated responses to use the updated format of "res.status(xxx).json(object)" or "res.status(xxx).end()" - Fix: If the :id attribute in the API does not evaluate to a valid mongoose ObjectID, it produces a Cast error. - Removed some unnecessary dependency injections where they were not being used.
|
Thanks for the PR @alexflorisca, but, it seems we have a slightly conflicting contribution here: #704 Perhaps these PRs should be merged, but then the separate changes be brought in different commits? |
|
No probs. Looks like I screwed something up as the test build failed so feel free to merge the other one in and leave this one. I will try and add those in manually later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.